[mypyc] Inline fast paths of integer unboxing operations #17266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Jun 5, 2024
mypyc/lib-rt/pythonsupport.c
Outdated
| } | ||
| } | ||
| /* Haven't lost any bits, but casting to long requires extra | ||
| * care (see comment above). |
There was a problem hiding this comment.
Maybe copy the comment referred here for completeness?
There was a problem hiding this comment.
I wasn't sure what it referred to, so I just removed the reference to the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to
intand native integer types.This speeds up this micro-benchmark by up to 80% (it spends most of the time
unboxing integers):
The impact to compile time when self-compiling is below the noise floor. The generated
binary is about 0.1% larger. Since integer unboxing can be performance-critical,
this seems like a decent win.
Closes mypyc/mypyc#987. Work on mypyc/mypyc#757.